language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 22:34:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Report errors for type errors in specializations outside of ability impl

Browse source
This commit is contained in:
Ayaz Hafiz 2022-04-12 18:41:20 -04:00
parent 127d435ff2
commit 16d0060824
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
2 changed files with 44 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
compiler/solve/src/solve.rs
View file

@ -806,6 +806,7 @@ fn solve(
let mut new_env = env.clone();
for (symbol, loc_var) in local_def_vars.iter() {
check_ability_specialization(
arena,
subs,
&new_env,
pools,
@ -1240,6 +1241,7 @@ fn solve(
/// does specialize the ability, and record the specialization.
#[allow(clippy::too_many_arguments)]
fn check_ability_specialization(
arena: &Bump,
subs: &mut Subs,
env: &Env,
pools: &mut Pools,
@ -1260,7 +1262,13 @@ fn check_ability_specialization(
// Check if they unify - if they don't, then the claimed specialization isn't really one,
// and that's a type error!
let snapshot = subs.snapshot();
// This also fixes any latent type variables that need to be specialized to exactly what
// the ability signature expects.
// We need to freshly instantiate the root signature so that all unifications are reflected
// in the specialization type, but not the original signature type.
let root_signature_var =
deep_copy_var_in(subs, Rank::toplevel(), pools, root_signature_var, arena);
let unified = unify(subs, symbol_loc_var.value, root_signature_var, Mode::EQ);
match unified {
@ -1268,10 +1276,6 @@ fn check_ability_specialization(
vars: _,
must_implement_ability,
} => {
// We don't actually care about storing the unified type since the checked type for the
// specialization is what we want for code generation.
subs.rollback_to(snapshot);
if must_implement_ability.is_empty() {
// This is an error.. but what kind?
}
@ -1305,7 +1309,6 @@ fn check_ability_specialization(
deferred_must_implement_abilities.extend(must_implement_ability);
}
Failure(vars, actual_type, expected_type, unimplemented_abilities) => {
subs.commit_snapshot(snapshot);
introduce(subs, rank, pools, &vars);
let reason = Reason::InvalidAbilityMemberSpecialization {
@ -1324,7 +1327,6 @@ fn check_ability_specialization(
problems.push(problem);
}
BadType(vars, problem) => {
subs.commit_snapshot(snapshot);
introduce(subs, rank, pools, &vars);
problems.push(TypeError::BadType(problem));