language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-31 17:17:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix bug in unifying records

Browse source 
This was leading us to have an infinitely-recursive type, which eventually causes layout to stack-overflow

Fixes #4739
This commit is contained in:
Joshua Warner 2022-12-15 19:12:12 -08:00
parent faaa466c70
commit 174f7d5e4d
No known key found for this signature in database
GPG key ID: 89AD497003F93FDD
5 changed files with 191 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

35
crates/compiler/solve/tests/solve_expr.rs
View file

@ -522,6 +522,41 @@ mod solve_expr {
);
}
#[test]
fn choose_correct_recursion_var_under_record() {
infer_queries!(
indoc!(
r#"
Parser : [
Specialize Parser,
Record (List {parser: Parser}),
]
printCombinatorParser : Parser -> Str
printCombinatorParser = \parser ->
when parser is
# ^^^^^^
Specialize p ->
printed = printCombinatorParser p
if Bool.false then printed else "foo"
Record fields ->
fields
|> List.map \f ->
printed = printCombinatorParser f.parser
if Bool.false then printed else "foo"
|> List.first
|> Result.withDefault ("foo")
printCombinatorParser (Record [])
"#
),
@r###"
parser : [Record (List { parser : a }), Specialize a] as a
"###
print_only_under_alias: true
);
}
// #[test]
// fn block_string_literal() {
// infer_eq(