language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 08:34:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Refactor the optimisation for immediately-returned Let statements

Browse source 
The original intention was to avoid creating a local when we define
and immediately return a primitive value. But now our default path
does avoids unnecessary locals anyway!

For StackMemory values we do need an optimised path but it's nicer
to just pass a flag to Storage::allocate.
This commit is contained in:
Brian Carroll 2021-10-18 13:18:10 +02:00
parent 2daefc8b32
commit 1b97675f1f
3 changed files with 37 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

21
compiler/gen_wasm/src/storage.rs
View file

@ -10,9 +10,10 @@ use crate::{
ALIGN_8, PTR_SIZE, PTR_TYPE,
};
pub enum LocalKind {
pub enum StoredValueKind {
Parameter,
Variable,
ReturnValue,
}
#[derive(Debug, Clone)]
@ -103,13 +104,13 @@ impl Storage {
&mut self,
wasm_layout: &WasmLayout,
symbol: Symbol,
kind: LocalKind,
kind: StoredValueKind,
) -> StoredValue {
let next_local_id = self.get_next_local_id();
let storage = match wasm_layout {
WasmLayout::Primitive(value_type, size) => match kind {
LocalKind::Parameter => {
StoredValueKind::Parameter => {
self.arg_types.push(*value_type);
StoredValue::Local {
local_id: next_local_id,
@ -117,7 +118,7 @@ impl Storage {
size: *size,
}
}
LocalKind::Variable => StoredValue::VirtualMachineStack {
_ => StoredValue::VirtualMachineStack {
vm_state: VirtualMachineSymbolState::NotYetPushed,
value_type: *value_type,
size: *size,
@ -126,8 +127,8 @@ impl Storage {
WasmLayout::HeapMemory => {
match kind {
LocalKind::Parameter => self.arg_types.push(PTR_TYPE),
LocalKind::Variable => self.local_types.push(PTR_TYPE),
StoredValueKind::Parameter => self.arg_types.push(PTR_TYPE),
_ => self.local_types.push(PTR_TYPE),
}
StoredValue::Local {
local_id: next_local_id,
@ -141,12 +142,12 @@ impl Storage {
alignment_bytes,
} => {
let location = match kind {
LocalKind::Parameter => {
StoredValueKind::Parameter => {
self.arg_types.push(PTR_TYPE);
StackMemoryLocation::PointerArg(next_local_id)
}
LocalKind::Variable => {
StoredValueKind::Variable => {
if self.stack_frame_pointer.is_none() {
self.stack_frame_pointer = Some(next_local_id);
self.local_types.push(PTR_TYPE);
@ -159,6 +160,10 @@ impl Storage {
StackMemoryLocation::FrameOffset(offset as u32)
}
StoredValueKind::ReturnValue => {
StackMemoryLocation::PointerArg(LocalId(0))
}
};
StoredValue::StackMemory {