language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-01 07:41:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Change usage of Wasm if instruction now that we don't support block results anymore

Browse source
This commit is contained in:
Brian Carroll 2021-12-21 23:02:40 +00:00
parent c3af4b1fb3
commit 1c20075d7b
3 changed files with 47 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

16
compiler/gen_wasm/src/wasm_module/code_builder.rs
View file

@ -551,7 +551,16 @@ impl<'a> CodeBuilder<'a> {
/// Emits the opcode and simulates VM stack push/pop
fn inst_base(&mut self, opcode: OpCode, pops: usize, push: bool) {
let current_stack = self.current_stack_mut();
let new_len = current_stack.len() - pops as usize;
let stack_size = current_stack.len();
debug_assert!(
stack_size >= pops,
"Wasm value stack underflow. Tried to pop {} but only {} available",
pops,
stack_size
);
let new_len = stack_size - pops as usize;
current_stack.truncate(new_len);
if push {
current_stack.push(Symbol::WASM_TMP);
@ -571,11 +580,6 @@ impl<'a> CodeBuilder<'a> {
/// Block instruction
fn inst_block(&mut self, opcode: OpCode, pops: usize, block_type: BlockType) {
if block_type != BlockType::NoResult {
// Returning from nested blocks is too complicated if we use result types
internal_error!("Block results are not supported.");
}
self.inst_base(opcode, pops, false);
self.code.push(block_type.as_byte());