language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-04 12:18:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Unsuffixed effectul function warning

Browse source
This commit is contained in:
Agus Zubiaga 2024-10-16 16:08:33 -03:00
parent 75856ae804
commit 1da8af390b
No known key found for this signature in database
5 changed files with 115 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

66
crates/compiler/load/tests/test_reporting.rs
View file

@ -14547,11 +14547,11 @@ All branches in an `if` must have the same type!
leftover_statement,
indoc!(
r#"
app [main] { pf: platform "../../../../../examples/cli/effects-platform/main.roc" }
app [main!] { pf: platform "../../../../../examples/cli/effects-platform/main.roc" }
import pf.Effect
main = \{} ->
main! = \{} ->
identity {}
Effect.putLine! "hello"
@ -14689,4 +14689,66 @@ All branches in an `if` must have the same type!
Num *
"###
);
test_report!(
function_def_fx_no_bang,
indoc!(
r#"
app [main!] { pf: platform "../../../../../examples/cli/effects-platform/main.roc" }
import pf.Effect
main! = \{} ->
printHello {}
printHello = \{} ->
Effect.putLine! "hello"
"#
),
@r###"
── MISSING EXCLAMATION in /code/proj/Main.roc ──────────────────────────────────
This function is effectful, but its name does not indicate so:
8│ printHello = \{} ->
^^^^^^^^^^
Add an exclamation mark at the end of its name, like:
printHello!
This will help readers identify it as a source of effects.
"###
);
test_report!(
nested_function_def_fx_no_bang,
indoc!(
r#"
app [main!] { pf: platform "../../../../../examples/cli/effects-platform/main.roc" }
import pf.Effect
main! = \{} ->
printHello = \{} ->
Effect.putLine! "hello"
printHello {}
"#
),
@r###"
── MISSING EXCLAMATION in /code/proj/Main.roc ──────────────────────────────────
This function is effectful, but its name does not indicate so:
6│ printHello = \{} ->
^^^^^^^^^^
Add an exclamation mark at the end of its name, like:
printHello!
This will help readers identify it as a source of effects.
"###
);
}