language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 05:49:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix package module resolution in inline imports

Browse source 
We were still passing `ModuleIds` from `load` to `can`, but now
that imports can appear in any scope, we don't know which package
an unqualified module name belongs to from the top level.

We now pass `PackageModuleIds` instead  and keep a Map of `ModuleName` to
`ModuleId` in `Scope`.

This also allow us to import multiple modules with the same name from different
packages as long as a unique alias is provided.
This commit is contained in:
Agus Zubiaga 2024-03-31 21:10:14 -03:00
parent 842a256907
commit 1f347f6ca1
No known key found for this signature in database
13 changed files with 398 additions and 309 deletions
Download patch file Download diff file Expand all files Collapse all files

27
crates/compiler/problem/src/can.rs
View file

@ -4,7 +4,7 @@ use std::path::PathBuf;
use roc_collections::all::MutSet;
use roc_module::called_via::BinOp;
use roc_module::ident::{Ident, Lowercase, ModuleName, TagName};
use roc_module::symbol::{ModuleId, Symbol};
use roc_module::symbol::{ModuleId, ScopeModuleSource, Symbol};
use roc_parse::ast::Base;
use roc_parse::pattern::PatternType;
use roc_region::all::{Loc, Region};
@ -40,11 +40,12 @@ pub enum Problem {
UnusedModuleImport(ModuleId, Region),
ExposedButNotDefined(Symbol),
UnknownGeneratesWith(Loc<Ident>),
ImportAliasConflict {
alias: String,
conflict: ImportAliasConflict,
module_id: ModuleId,
region: Region,
ImportNameConflict {
name: ModuleName,
is_alias: bool,
new_module_id: ModuleId,
new_import_region: Region,
existing_import: ScopeModuleSource,
},
/// First symbol is the name of the closure with that argument
/// Bool is whether the closure is anonymous
@ -219,13 +220,6 @@ pub enum Problem {
},
}
#[derive(Clone, Debug, PartialEq, Eq)]
pub enum ImportAliasConflict {
Alias(ModuleId, Region),
Module(Region),
Builtin,
}
impl Problem {
pub fn severity(&self) -> Severity {
use Severity::{Fatal, RuntimeError, Warning};
@ -234,7 +228,7 @@ impl Problem {
Problem::UnusedDef(_, _) => Warning,
Problem::UnusedImport(_, _) => Warning,
Problem::UnusedModuleImport(_, _) => Warning,
Problem::ImportAliasConflict { .. } => RuntimeError,
Problem::ImportNameConflict { .. } => RuntimeError,
Problem::ExposedButNotDefined(_) => RuntimeError,
Problem::UnknownGeneratesWith(_) => RuntimeError,
Problem::UnusedArgument(_, _, _, _) => Warning,
@ -309,7 +303,10 @@ impl Problem {
}
| Problem::UnusedImport(_, region)
| Problem::UnusedModuleImport(_, region)
| Problem::ImportAliasConflict { region, .. }
| Problem::ImportNameConflict {
new_import_region: region,
..
}
| Problem::UnknownGeneratesWith(Loc { region, .. })
| Problem::UnusedArgument(_, _, _, region)
| Problem::UnusedBranchDef(_, region)