language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 14:54:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Two non-functional problem reports

Browse source
This commit is contained in:
Chad Stearns 2020-03-29 14:28:06 -04:00
parent a00ed8a1ca
commit 221581432a
4 changed files with 142 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
compiler/can/src/expr.rs
View file

@ -431,20 +431,19 @@ pub fn canonicalize_expr<'a>(
loc_body_expr.region,
&loc_body_expr.value,
);
// Now that we've collected all the references, check to see if any of the args we defined
// went unreferenced. If any did, report them as unused arguments.
for (symbol, region) in scope.symbols() {
if !original_scope.contains_symbol(*symbol) {
if !output.references.has_lookup(*symbol) {
for (sub_symbol, region) in scope.symbols() {
if !original_scope.contains_symbol(*sub_symbol) {
if !output.references.has_lookup(*sub_symbol) {
// The body never referenced this argument we declared. It's an unused argument!
env.problem(Problem::UnusedArgument(*symbol, *region));
env.problem(Problem::UnusedArgument(symbol, *sub_symbol, *region));
}
// We shouldn't ultimately count arguments as referenced locals. Otherwise,
// we end up with weird conclusions like the expression (\x -> x + 1)
// references the (nonexistant) local variable x!
output.references.lookups.remove(symbol);
output.references.lookups.remove(sub_symbol);
}
}