language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-07-19 04:25:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

if the user reserves a specific number of elements, trust them

Browse source
This commit is contained in:
Brendan Hansknecht 2025-01-01 13:00:34 -08:00
parent 8001de5468
commit 26bd2d437e
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
crates/compiler/builtins/bitcode/src/utils.zig
View file

@ -469,15 +469,16 @@ pub inline fn calculateCapacity(
requested_length: usize,
element_width: usize,
) usize {
// TODO: there are two adjustments that would likely lead to better results for Roc.
// 1. Deal with the fact we allocate an extra u64 for refcount.
// This may lead to allocating page size + 8 bytes.
// That could mean allocating an entire page for 8 bytes of data which isn't great.
// 2. Deal with the fact that we can request more than 1 element at a time.
// fbvector assumes just appending 1 element at a time when using this algorithm.
// As such, they will generally grow in a way that should better match certain memory multiple.
// This is also the normal case for roc, but we could also grow by a much larger amount.
// We may want to round to multiples of 2 or something similar.
// TODO: Deal with the fact we allocate an extra u64 for refcount.
// This may lead to allocating page size + 8 bytes.
// That could mean allocating an entire page for 8 bytes of data which isn't great.
if (requested_length != old_capacity + 1) {
// The user is explicitly requesting n elements.
// Trust the user and just reserve that amount.
return requested_length;
}
var new_capacity: usize = 0;
if (element_width == 0) {
return requested_length;