language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 06:44:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Add some comments and TODOs

Browse source
This commit is contained in:
Brendan Hansknecht 2022-02-24 20:40:45 -08:00
parent ba2e8cd32b
commit 27b47713aa
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/gen_llvm/src/llvm/build_list.rs
View file

@ -294,19 +294,22 @@ pub fn list_drop_at<'a, 'ctx, 'env>(
/// List.replace : List elem, Nat, elem -> List elem
pub fn list_replace<'a, 'ctx, 'env>(
env: &Env<'a, 'ctx, 'env>,
layout_ids: &mut LayoutIds<'a>,
_layout_ids: &mut LayoutIds<'a>,
list: BasicValueEnum<'ctx>,
index: IntValue<'ctx>,
element: BasicValueEnum<'ctx>,
element_layout: &Layout<'a>,
update_mode: UpdateMode,
) -> BasicValueEnum<'ctx> {
// TODO: This or elsewhere needs to deal with building the record that gets returned.
let (length, bytes) = load_list(
env.builder,
list.into_struct_value(),
env.context.i8_type().ptr_type(AddressSpace::Generic),
);
// Assume the bounds have already been checked earlier
// (e.g. by List.replace or List.set, which wrap List.#replaceUnsafe)
let new_bytes = match update_mode {
UpdateMode::InPlace => call_bitcode_fn(
env,