language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 06:14:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

short-circuit loading field from size 0 struct

Browse source
This commit is contained in:
Folkert 2023-04-30 16:55:17 +02:00
parent 37eec2b7c2
commit 29bc9a2e85
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/compiler/gen_dev/src/generic64/storage.rs
View file

@ -542,13 +542,21 @@ impl<
field_layouts: &'a [InLayout<'a>], field_layouts: &'a [InLayout<'a>],
) { ) {
debug_assert!(index < field_layouts.len() as u64); debug_assert!(index < field_layouts.len() as u64);
let storage = *self.get_storage_for_sym(structure);
if let NoData = storage {
return self.no_data(sym);
}
// This must be removed and reinserted for ownership and mutability reasons. // This must be removed and reinserted for ownership and mutability reasons.
let owned_data = self.remove_allocation_for_sym(structure); let owned_data = self.remove_allocation_for_sym(structure);
self.allocation_map self.allocation_map
.insert(*structure, Rc::clone(&owned_data)); .insert(*structure, Rc::clone(&owned_data));
match self.get_storage_for_sym(structure) {
match storage {
Stack(Complex { base_offset, size }) => { Stack(Complex { base_offset, size }) => {
let (base_offset, size) = (*base_offset, *size); let (base_offset, size) = (base_offset, size);
let mut data_offset = base_offset; let mut data_offset = base_offset;
for layout in field_layouts.iter().take(index as usize) { for layout in field_layouts.iter().take(index as usize) {
let field_size = layout_interner.stack_size(*layout); let field_size = layout_interner.stack_size(*layout);