language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 14:24:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

parse default optional expressions in pattern matches

Browse source
This commit is contained in:
Folkert 2020-07-20 00:52:16 +02:00
parent 3656257191
commit 29c3eebace
6 changed files with 209 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

19
compiler/parse/src/ast.rs
View file

@ -322,7 +322,7 @@ pub enum Pattern<'a> {
/// An optional field pattern, e.g. { x ? Just 0 } -> ...
/// Can only occur inside of a RecordDestructure
OptionalField(&'a str, &'a Loc<Pattern<'a>>),
OptionalField(&'a str, &'a Loc<Expr<'a>>),
/// This is used only to avoid cloning when reordering expressions (e.g. in desugar()).
/// It lets us take an (&Expr) and create a plain (Expr) from it.
@ -428,8 +428,21 @@ impl<'a> Pattern<'a> {
(RequiredField(x, inner_x), RequiredField(y, inner_y)) => {
x == y && inner_x.value.equivalent(&inner_y.value)
}
(OptionalField(x, inner_x), OptionalField(y, inner_y)) => {
x == y && inner_x.value.equivalent(&inner_y.value)
(OptionalField(x, _inner_x), OptionalField(y, _inner_y)) => {
x == y
// TODO
//
// We can give an annotation like so
//
// { x, y } : { x : Int, y : Bool }
// { x, y } = rec
//
// But what about:
//
// { x, y ? False } : { x : Int, y ? Bool }
// { x, y ? False } = rec
//
// inner_x.value.equivalent(&inner_y.value)
}
(Nested(x), Nested(y)) => x.equivalent(y),