language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-12-09 10:55:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

only include non-duplicate record fields in CIR

Browse source
This commit is contained in:
Luke Boswell 2025-06-26 14:10:12 +10:00
parent addbed5c65
commit 341e04cc43
No known key found for this signature in database
GPG key ID: 54A7324B1B975757
2 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/check/canonicalize.zig
View file

@ -1317,12 +1317,17 @@ pub fn canonicalize_expr(
.ident = field_name_ident,
.region = field_name_region,
}) catch |err| exitOnOom(err);
}
}
// Continue with normal canonicalization
if (self.canonicalize_record_field(field)) |canonicalized| {
self.can_ir.store.scratch_record_fields.append(self.can_ir.env.gpa, canonicalized);
// Only canonicalize and include non-duplicate fields
if (self.canonicalize_record_field(field)) |canonicalized| {
self.can_ir.store.scratch_record_fields.append(self.can_ir.env.gpa, canonicalized);
}
}
} else {
// Field name couldn't be resolved, still try to canonicalize
if (self.canonicalize_record_field(field)) |canonicalized| {
self.can_ir.store.scratch_record_fields.append(self.can_ir.env.gpa, canonicalized);
}
}
}

11
src/snapshots/records/error_duplicate_fields.md
View file

@ -69,23 +69,18 @@ NO CHANGE
~~~
# CANONICALIZE
~~~clojure
(e-record @1-1-1-77 (record-var 91) (ext-var 0) (id 93)
(e-record @1-1-1-77 (record-var 84) (ext-var 0) (id 86)
(fields
(field (name "name")
(e-string @1-9-1-16
(e-literal @1-10-1-15 (string "Alice"))))
(field (name "age")
(e-int @1-23-1-25 (num-var 77) (sign-needed "false") (bits-needed "7") (value "30")))
(field (name "name")
(e-string @1-33-1-38
(e-literal @1-34-1-37 (string "Bob"))))
(field (name "email")
(e-string @1-47-1-66
(e-literal @1-48-1-65 (string "alice@example.com"))))
(field (name "age")
(e-int @1-73-1-75 (num-var 89) (sign-needed "false") (bits-needed "7") (value "25")))))
(e-literal @1-48-1-65 (string "alice@example.com"))))))
~~~
# TYPES
~~~clojure
(expr (id 93) (type "*"))
(expr (id 86) (type "*"))
~~~