language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Reject implementations that don't point to abilities

Browse source
This commit is contained in:
Ayaz Hafiz 2022-07-19 13:21:08 -04:00
parent a53de2e05c
commit 37ab06b0a3
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 52 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

19
crates/compiler/can/src/def.rs
View file

@ -565,10 +565,23 @@ fn canonicalize_opaque<'a>(
_ => internal_error!("spaces not extracted"),
};
let ability_region = ability.region;
let ability = match ability.value {
ast::TypeAnnotation::Apply(module_name, ident, []) => {
match make_apply_symbol(env, region, scope, module_name, ident) {
Ok(ability) => ability,
Ok(ability) => {
if scope.abilities_store.is_ability(ability)
|| pending_abilities_in_scope.contains(&ability)
{
// This is an ability we already imported into the scope,
// or which is also undergoing canonicalization at the moment.
ability
} else {
env.problem(Problem::NotAnAbility(ability_region));
continue;
}
}
Err(_) => {
// This is bad apply; an error will have been reported for it
// already.
@ -578,7 +591,7 @@ fn canonicalize_opaque<'a>(
}
_ => {
// Register the problem but keep going.
env.problem(Problem::IllegalClaimedAbility(region));
env.problem(Problem::NotAnAbility(ability_region));
continue;
}
};
@ -628,7 +641,7 @@ fn canonicalize_opaque<'a>(
//
// Register the problem but keep going, we may still be able to compile the
// program even if a derive is missing.
env.problem(Problem::IllegalClaimedAbility(region));
env.problem(Problem::IllegalDerivedAbility(region));
}
}