language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-01 07:41:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

enforce only one direct host-exposed specialization

Browse source
This commit is contained in:
Folkert 2021-11-19 23:30:35 +01:00
parent 88a1a0fd40
commit 38b5e627d7
1 changed files with 21 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

42
compiler/mono/src/ir.rs
View file

@ -354,8 +354,7 @@ impl<'a> Proc<'a> {
} }
} }
type ExposedAliases = std::vec::Vec<(Symbol, Variable)>; /// A host-exposed function must be specialized; it's a seed for subsequent specializations
#[derive(Clone, Debug)] #[derive(Clone, Debug)]
pub struct HostSpecializations { pub struct HostSpecializations {
/// Not a bumpalo vec because bumpalo is not thread safe /// Not a bumpalo vec because bumpalo is not thread safe
@ -363,9 +362,9 @@ pub struct HostSpecializations {
symbols: std::vec::Vec<Symbol>, symbols: std::vec::Vec<Symbol>,
storage_subs: StorageSubs, storage_subs: StorageSubs,
/// For each symbol, what types to specialize it for, points into the storage_subs /// For each symbol, what types to specialize it for, points into the storage_subs
types_to_specialize: std::vec::Vec<std::vec::Vec<Variable>>, types_to_specialize: std::vec::Vec<Variable>,
/// Variables for an exposed alias /// Variables for an exposed alias
exposed_aliases: std::vec::Vec<std::vec::Vec<std::vec::Vec<(Symbol, Variable)>>>, exposed_aliases: std::vec::Vec<std::vec::Vec<(Symbol, Variable)>>,
} }
impl Default for HostSpecializations { impl Default for HostSpecializations {
@ -402,17 +401,14 @@ impl HostSpecializations {
match self.symbols.iter().position(|s| *s == symbol) { match self.symbols.iter().position(|s| *s == symbol) {
None => { None => {
self.symbols.push(symbol); self.symbols.push(symbol);
self.types_to_specialize.push(vec![variable]); self.types_to_specialize.push(variable);
self.exposed_aliases.push(vec![host_exposed_aliases]); self.exposed_aliases.push(host_exposed_aliases);
} }
Some(index) => { Some(_) => {
let types_to_specialize = &mut self.types_to_specialize[index]; // we assume that only one specialization of a function is directly exposed to the
let exposed_aliases = &mut self.exposed_aliases[index]; // host. Other host-exposed symbols may (transitively) specialize this symbol,
// but then the existing specialization mechanism will find those specializations
debug_assert_eq!(types_to_specialize.len(), exposed_aliases.len()); panic!("A host-exposed symbol can only be exposed once");
types_to_specialize.push(variable);
exposed_aliases.push(host_exposed_aliases);
} }
} }
@ -423,13 +419,7 @@ impl HostSpecializations {
self, self,
) -> ( ) -> (
StorageSubs, StorageSubs,
impl Iterator< impl Iterator<Item = (Symbol, Variable, std::vec::Vec<(Symbol, Variable)>)>,
Item = (
Symbol,
std::vec::Vec<Variable>,
std::vec::Vec<ExposedAliases>,
),
>,
) { ) {
let it1 = self.symbols.into_iter(); let it1 = self.symbols.into_iter();
@ -443,6 +433,7 @@ impl HostSpecializations {
} }
} }
/// Specializations of this module's symbols that other modules need
#[derive(Clone, Debug)] #[derive(Clone, Debug)]
pub struct ExternalSpecializations<'a> { pub struct ExternalSpecializations<'a> {
/// Not a bumpalo vec because bumpalo is not thread safe /// Not a bumpalo vec because bumpalo is not thread safe
@ -2029,22 +2020,17 @@ fn specialize_host_specializations<'a>(
let offset_variable = StorageSubs::merge_into(store, env.subs); let offset_variable = StorageSubs::merge_into(store, env.subs);
for (symbol, solved_types, host_exposed_aliases) in it { for (symbol, variable, host_exposed_aliases) in it {
let it = solved_types
.into_iter()
.zip(host_exposed_aliases.into_iter());
for (store_variable, host_exposed_aliases) in it {
barfoo( barfoo(
env, env,
procs, procs,
layout_cache, layout_cache,
symbol, symbol,
offset_variable(store_variable), offset_variable(variable),
&host_exposed_aliases, &host_exposed_aliases,
) )
} }
} }
}
fn specialize_external_specializations<'a>( fn specialize_external_specializations<'a>(
env: &mut Env<'a, '_>, env: &mut Env<'a, '_>,