language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-30 07:14:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Add linker data for strings, and deduplicate them

Browse source 
For references to addresses of constant strings, we make an entry in
reloc.CODE and configure the relocation type to say it points at a
memory address. (At least I think this is right, I can't test it yet!)

The same info can also be used for de-duplication.

It turns out we don't need reloc.DATA. I had misunderstood it.
The use case for that would be constant nested data structures,
where constant data would contain pointers to other constant data.
I don't think we're doing this in Roc at all, but not sure.
This commit is contained in:
Brian Carroll 2021-11-06 10:25:10 +00:00
parent 2f0296a5fa
commit 38d9fc5bbd
5 changed files with 113 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

17
compiler/gen_wasm/src/wasm_module/sections.rs
View file

@ -614,8 +614,7 @@ pub struct WasmModule<'a> {
pub code: CodeSection<'a>,
pub data: DataSection<'a>,
pub linking: LinkingSection<'a>,
pub reloc_code: RelocationSection<'a>,
pub reloc_data: RelocationSection<'a>,
pub relocations: RelocationSection<'a>,
}
impl<'a> WasmModule<'a> {
@ -654,22 +653,16 @@ impl<'a> WasmModule<'a> {
let data_count_section = DataCountSection::new(&self.data);
counter.serialize_and_count(buffer, &data_count_section);
// Code section mutates its linker relocation data during serialization
// Code section is the only one with relocations so we can stop counting
let code_section_index = counter.section_index;
self.code
.serialize_with_relocs(buffer, &mut self.reloc_code.entries);
counter.update(buffer);
.serialize_with_relocs(buffer, &mut self.relocations.entries);
// Data section is the last one before linking, so we can stop counting
let data_section_index = counter.section_index;
self.data.serialize(buffer);
self.linking.serialize(buffer);
self.reloc_code.target_section_index = Some(code_section_index);
self.reloc_code.serialize(buffer);
self.reloc_data.target_section_index = Some(data_section_index);
self.reloc_data.serialize(buffer);
self.relocations.target_section_index = Some(code_section_index);
self.relocations.serialize(buffer);
}
}