language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-07-19 04:25:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix two bugs in the dev backend

Browse source
This commit is contained in:
Folkert 2023-09-12 17:35:08 +02:00
parent dfee6740dd
commit 3909443ef4
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
4 changed files with 92 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

52
crates/compiler/builtins/bitcode/src/utils.zig
View file

@ -4,6 +4,8 @@ const always_inline = std.builtin.CallOptions.Modifier.always_inline;
const Monotonic = std.builtin.AtomicOrder.Monotonic;
const DEBUG_INCDEC = false;
const DEBUG_TESTING_ALLOC = false;
const DEBUG_ALLOC = false;
pub fn WithOverflow(comptime T: type) type {
return extern struct { value: T, has_overflowed: bool };
@ -60,19 +62,35 @@ comptime {
}
fn testing_roc_alloc(size: usize, _: u32) callconv(.C) ?*anyopaque {
return @ptrCast(?*anyopaque, std.testing.allocator.alloc(u8, size) catch unreachable);
const ptr = @ptrCast(?*anyopaque, std.testing.allocator.alloc(u8, size) catch unreachable);
if (DEBUG_TESTING_ALLOC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("+ alloc {*}: {} bytes\n", .{ ptr, size });
}
return ptr;
}
fn testing_roc_realloc(c_ptr: *anyopaque, new_size: usize, old_size: usize, _: u32) callconv(.C) ?*anyopaque {
const ptr = @ptrCast([*]u8, @alignCast(2 * @alignOf(usize), c_ptr));
const slice = ptr[0..old_size];
return @ptrCast(?*anyopaque, std.testing.allocator.realloc(slice, new_size) catch unreachable);
const new = @ptrCast(?*anyopaque, std.testing.allocator.realloc(slice, new_size) catch unreachable);
if (DEBUG_TESTING_ALLOC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("- realloc {*}\n", .{new});
}
return new;
}
fn testing_roc_dealloc(c_ptr: *anyopaque, _: u32) callconv(.C) void {
const ptr = @ptrCast([*]u8, @alignCast(2 * @alignOf(usize), c_ptr));
if (DEBUG_TESTING_ALLOC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("💀 dealloc {*}\n", .{ptr});
}
std.testing.allocator.destroy(ptr);
}
@ -88,6 +106,9 @@ pub fn alloc(size: usize, alignment: u32) ?[*]u8 {
}
pub fn realloc(c_ptr: [*]u8, new_size: usize, old_size: usize, alignment: u32) [*]u8 {
if (DEBUG_INCDEC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("- realloc {*}\n", .{c_ptr});
}
return @ptrCast([*]u8, roc_realloc(c_ptr, new_size, old_size, alignment));
}
@ -269,9 +290,18 @@ inline fn free_ptr_to_refcount(
) void {
if (RC_TYPE == Refcount.none) return;
const extra_bytes = std.math.max(alignment, @sizeOf(usize));
const allocation_ptr = @ptrCast([*]u8, refcount_ptr) - (extra_bytes - @sizeOf(usize));
if (DEBUG_ALLOC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("💀 free {*}\n", .{allocation_ptr});
}
// NOTE: we don't even check whether the refcount is "infinity" here!
dealloc(@ptrCast([*]u8, refcount_ptr) - (extra_bytes - @sizeOf(usize)), alignment);
dealloc(allocation_ptr, alignment);
if (DEBUG_ALLOC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("💀 freed {*}\n", .{allocation_ptr});
}
}
inline fn decref_ptr_to_refcount(
@ -326,12 +356,12 @@ pub fn isUnique(
const isizes: [*]isize = @intToPtr([*]isize, masked_ptr);
if (DEBUG_INCDEC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("| is unique {*}\n", .{&bytes[0]});
}
const refcount = (isizes - 1)[0];
if (DEBUG_INCDEC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("| is unique {*}\n", .{isizes});
}
return refcount == REFCOUNT_ONE_ISIZE;
}
@ -398,8 +428,16 @@ pub fn allocateWithRefcount(
const alignment = std.math.max(ptr_width, element_alignment);
const length = alignment + data_bytes;
if (DEBUG_ALLOC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("+ before allocate {} {} {} \n", .{ data_bytes, element_alignment, length });
}
var new_bytes: [*]u8 = alloc(length, alignment) orelse unreachable;
if (DEBUG_ALLOC and builtin.target.cpu.arch != .wasm32) {
std.debug.print("+ allocated {*}\n", .{new_bytes});
}
const data_ptr = new_bytes + alignment;
const refcount_ptr = @ptrCast([*]usize, @alignCast(ptr_width, data_ptr) - ptr_width);
refcount_ptr[0] = if (RC_TYPE == Refcount.none) REFCOUNT_MAX_ISIZE else REFCOUNT_ONE;