language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-02 08:11:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Do not provide hover when data missing

Browse source
This commit is contained in:
Ayaz Hafiz 2023-10-22 09:38:28 -04:00
parent 703ef6608e
commit 40f297445d
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 20 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

39
crates/lang_srv/src/registry.rs
View file

@ -3,9 +3,8 @@ use std::collections::HashMap;
use bumpalo::Bump; use bumpalo::Bump;
use roc_load::{LoadedModule, LoadingProblem}; use roc_load::{LoadedModule, LoadingProblem};
use roc_packaging::cache::{self, RocCacheDir}; use roc_packaging::cache::{self, RocCacheDir};
use roc_region::all::{LineInfo, Region}; use roc_region::all::LineInfo;
use roc_reporting::report::RocDocAllocator; use roc_reporting::report::RocDocAllocator;
use roc_types::subs::Variable;
use tower_lsp::lsp_types::{Diagnostic, Hover, HoverContents, MarkedString, Position, Range, Url}; use tower_lsp::lsp_types::{Diagnostic, Hover, HoverContents, MarkedString, Position, Range, Url};
use crate::convert::{ use crate::convert::{
@ -180,25 +179,11 @@ impl Document {
Some(m) => (&mut m.solved_subs, &m.decls), Some(m) => (&mut m.solved_subs, &m.decls),
None => match module.declarations_by_id.get(&module.module_id) { None => match module.declarations_by_id.get(&module.module_id) {
Some(decls) => (&mut module.solved, decls), Some(decls) => (&mut module.solved, decls),
None => { None => return missing_hover(module, position),
return Some(Hover {
contents: HoverContents::Scalar(MarkedString::String(format!(
"{:?}",
(module.typechecked.keys().collect::<Vec<_>>())
))),
range: Some(Range::new(
position,
Position {
line: position.line,
character: position.character + 1,
},
)),
})
}
}, },
}; };
let (region, var) = roc_can::traverse::find_closest_type_at(region, decls)
.unwrap_or_else(|| (Region::new(region, region.bump_column(1)), Variable::NULL)); let (region, var) = roc_can::traverse::find_closest_type_at(region, decls)?;
let subs = subs.inner_mut(); let subs = subs.inner_mut();
let snapshot = subs.snapshot(); let snapshot = subs.snapshot();
@ -220,6 +205,22 @@ impl Document {
} }
} }
fn missing_hover(module: &mut LoadedModule, position: Position) -> Option<Hover> {
Some(Hover {
contents: HoverContents::Scalar(MarkedString::String(format!(
"{:?}",
(module.typechecked.keys().collect::<Vec<_>>())
))),
range: Some(Range::new(
position,
Position {
line: position.line,
character: position.character + 1,
},
)),
})
}
#[derive(Debug, Default)] #[derive(Debug, Default)]
pub(crate) struct Registry { pub(crate) struct Registry {
documents: HashMap<Url, Document>, documents: HashMap<Url, Document>,