language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 21:39:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Don't print warnings in the REPL

Browse source
This commit is contained in:
Richard Feldman 2022-10-30 03:12:27 -04:00
parent 5110727795
commit 45e800c328
No known key found for this signature in database
GPG key ID: F1F21AA5B1D9E43B
1 changed files with 4 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

44
crates/repl_cli/src/repl_state.rs
View file

@ -214,34 +214,7 @@ impl ReplState {
} }
}; };
format_output(output, problems, |warning| { format_output(output, problems)
// Filter out UNUSED warnings for entries in past_def_idents,
// since otherwise those are totally unhelpful and very annoying!
//
// Obviously doing string matching on the error message itself is a
// brittle and hacky way to do this. It would be nice in the future to
// thread the authoritative information through here, but that's
// too large a change to justify in the first (already very large)
// implementation of the "remembered defs" feature!
const UNUSED_DEF_SHORT_PREFIX: &str = "\u{1b}[36m── UNUSED DEFINITION ─";
const UNUSED_DEF_FULL_PREFIX:&str = "\u{1b}[36m── UNUSED DEFINITION ───────────────────────────────────────────────────────────\u{1b}[0m\n\n\u{1b}[34m";
if warning.starts_with(UNUSED_DEF_SHORT_PREFIX) {
let ident_start = &warning[UNUSED_DEF_FULL_PREFIX.len()..];
if let Some(ident_len) = ident_start.find("\u{1b}[0m") {
let ident = &ident_start[..ident_len];
// If this is an unused definition warning for an entry
// in our past_def_idents, filter it out.
if self.past_def_idents.contains(ident) {
return false;
}
}
}
true
})
} }
fn next_auto_ident(&mut self) -> u64 { fn next_auto_ident(&mut self) -> u64 {
@ -423,20 +396,11 @@ impl Validator for ReplState {
} }
} }
fn format_output<F: FnMut(&&String) -> bool>( fn format_output(opt_output: Option<ReplOutput>, problems: Problems) -> String {
opt_output: Option<ReplOutput>,
problems: Problems,
warning_filter: F,
) -> String {
let mut buf = String::new(); let mut buf = String::new();
// Join all the warnings and errors together with blank lines. // Only print errors; discard warnings.
for message in problems for message in problems.errors.iter() {
.warnings
.iter()
.filter(warning_filter)
.chain(problems.errors.iter())
{
if !buf.is_empty() { if !buf.is_empty() {
buf.push_str("\n\n"); buf.push_str("\n\n");
} }