language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 13:59:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

add failing tests

Browse source 
* SIGSEGV for non-empty strings
This commit is contained in:
Dan Knutson 2021-10-23 10:16:30 -05:00
parent e7523ad41d
commit 46365da73a
3 changed files with 46 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
compiler/builtins/bitcode/src/str.zig
View file

@ -1504,14 +1504,12 @@ test "isWhitespace" {
try expect(!isWhitespace('x'));
}
pub fn strTrim(string: RocStr) callconv(.C) RocStr {
return @call(.{ .modifier = always_inline }, trim, .{string});
}
// TODO GIESCH
// ask & read about small & large strings
fn trim(string: RocStr) RocStr {
if (string.isEmpty()) return RocStr.empty();
pub fn strTrim(string: RocStr) callconv(.C) RocStr {
if (string.isEmpty()) {
return RocStr.empty();
}
const leading_bytes = countLeadingWhitespaceBytes(string);
const trailing_bytes = countTrailingWhitespaceBytes(string);
@ -1525,6 +1523,8 @@ fn trim(string: RocStr) RocStr {
// should this just use isUnique? (are all small strings safe for mutation?)
// should we rename isUnique to isUnleakable or something?
// could also just inline the unsafe reallocate call
// SIGSEGV is not from this branch
if (string.isRefcountOne()) {
const dest = string.str_bytes orelse unreachable;
const source = dest + leading_bytes;
@ -1645,6 +1645,3 @@ test "strTrim: unique hello world" {
try expect(trimmed.eq(expected));
}
// TODO GIESCH
// add top level roc tests