language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-04 12:18:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Change docs/errors from "optional" to "default value" record fields

Browse source 
I strongly believe that seeing the word "optional" is priming people wrong when it comes to this feature.
Especially given roc dose not have an `Optional/Option/Maybe` type, so users look for an alternative and find this.

This PR changes the name to "default value record fields".
It updates all docs and errors.
It does not update compiler internal naming.
That can be updated in a follow up PR if we want to, but I am also fine leaving it cause it is not exposed to users.
This commit is contained in:
Brendan Hansknecht 2024-04-03 08:47:26 -07:00
parent 185262510c
commit 482c084096
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
6 changed files with 38 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/compiler/derive_key/src/lib.rs
View file

@ -8,7 +8,7 @@
//! `{ b: "" }` have different derived implementations. However, it does not need to distinguish
//! between e.g. required and optional record fields.
//! - `Decoding` is like encoding, but has some differences. For one, it *does* need to distinguish
//! between required and optional record fields.
//! between required and default value record fields.
//!
//! For these reasons the content keying is based on a strategy as well, which are the variants of
//! [`DeriveKey`].