language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-02 16:21:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

replicate unused module check after canonicalization

Browse source
This commit is contained in:
Folkert 2022-03-13 17:03:54 +01:00
parent 563ba6acbb
commit 496c283491
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

24
compiler/load/src/file.rs
View file

@ -1730,6 +1730,28 @@ fn update<'a>(
state.module_cache.documentation.insert(module_id, docs);
}
{
// see if there are imported modules from which nothing is actually used
let mut unused_imported_modules = constrained_module.imported_modules.clone();
for symbol in constrained_module.module.referenced_values.iter() {
unused_imported_modules.remove(&symbol.module_id());
}
for symbol in constrained_module.module.referenced_types.iter() {
unused_imported_modules.remove(&symbol.module_id());
}
let existing = match state.module_cache.can_problems.entry(module_id) {
Vacant(entry) => entry.insert(std::vec::Vec::new()),
Occupied(entry) => entry.into_mut(),
};
for (unused, region) in unused_imported_modules.drain() {
existing.push(roc_problem::can::Problem::UnusedImport(unused, region));
}
}
state
.module_cache
.aliases
@ -3027,7 +3049,7 @@ fn send_header_two<'a>(
impl<'a> BuildTask<'a> {
// TODO trim down these arguments - possibly by moving Constraint into Module
#[allow(clippy::too_many_arguments)]
pub fn solve_module(
fn solve_module(
module: Module,
ident_ids: IdentIds,
module_timing: ModuleTiming,