language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-02 00:01:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Eq for empty list

Browse source
This commit is contained in:
Brian Carroll 2021-12-22 09:19:35 +00:00
parent e9ae8452b0
commit 4a970f089a
2 changed files with 16 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

25
compiler/mono/src/code_gen_help.rs
View file

@ -269,7 +269,7 @@ impl<'a> CodeGenHelp<'a> {
new_procs_info.push((symbol, proc_layout)); new_procs_info.push((symbol, proc_layout));
let mut visit_child = |child| { let mut visit_child = |child| {
if layout_needs_helper_proc(child, op) && child.stack_size(self.ptr_size) > 0 { if layout_needs_helper_proc(child, op) {
self.get_or_create_proc_symbols_visit(ident_ids, new_procs_info, op, child); self.get_or_create_proc_symbols_visit(ident_ids, new_procs_info, op, child);
} }
}; };
@ -411,10 +411,6 @@ impl<'a> CodeGenHelp<'a> {
sub_layout: &Layout<'a>, sub_layout: &Layout<'a>,
arguments: &[Symbol], arguments: &[Symbol],
) -> Expr<'a> { ) -> Expr<'a> {
if matches!(op, HelperOp::Eq) && sub_layout.stack_size(self.ptr_size) == 0 {
return Expr::Literal(Literal::Int(1));
}
let found = self let found = self
.specs .specs
.iter() .iter()
@ -1293,13 +1289,22 @@ fn layout_needs_helper_proc(layout: &Layout, op: HelperOp) -> bool {
Layout::Builtin(Builtin::Int(_) | Builtin::Float(_) | Builtin::Bool | Builtin::Decimal) => { Layout::Builtin(Builtin::Int(_) | Builtin::Float(_) | Builtin::Bool | Builtin::Decimal) => {
false false
} }
Layout::Builtin(Builtin::Str) => { Layout::Builtin(Builtin::Str) => {
// Str type can use either Zig functions or generated IR, since it's not generic.
// Eq uses a Zig function, refcount uses generated IR.
// Both are fine, they were just developed at different times.
matches!(op, HelperOp::Inc | HelperOp::Dec | HelperOp::DecRef) matches!(op, HelperOp::Inc | HelperOp::Dec | HelperOp::DecRef)
} }
Layout::Builtin(Builtin::Dict(_, _) | Builtin::Set(_) | Builtin::List(_))
| Layout::Struct(_) Layout::Builtin(Builtin::Dict(_, _) | Builtin::Set(_) | Builtin::List(_)) => true,
| Layout::Union(_)
| Layout::LambdaSet(_) => true, Layout::Struct(fields) => !fields.is_empty(),
Layout::RecursivePointer => false,
Layout::Union(UnionLayout::NonRecursive(tags)) => !tags.is_empty(),
Layout::Union(_) => true,
Layout::LambdaSet(_) | Layout::RecursivePointer => false,
} }
} }

2
compiler/test_gen/src/gen_compare.rs
View file

@ -460,7 +460,7 @@ fn rosetree_with_tag() {
} }
#[test] #[test]
#[cfg(any(feature = "gen-llvm"))] #[cfg(any(feature = "gen-llvm", feature = "gen-wasm"))]
fn list_eq_empty() { fn list_eq_empty() {
assert_evals_to!("[] == []", true, bool); assert_evals_to!("[] == []", true, bool);
assert_evals_to!("[] != []", false, bool); assert_evals_to!("[] != []", false, bool);