language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 08:34:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

correct pointer alignment on decref

Browse source
This commit is contained in:
Brendan Hansknecht 2024-07-12 17:52:50 -07:00
parent d4b86a745b
commit 4e8f916204
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/compiler/builtins/bitcode/src/utils.zig
View file

@ -337,7 +337,7 @@ inline fn free_ptr_to_refcount(
inline fn decref_ptr_to_refcount( inline fn decref_ptr_to_refcount(
refcount_ptr: [*]isize, refcount_ptr: [*]isize,
alignment: u32, element_alignment: u32,
elements_refcounted: bool, elements_refcounted: bool,
) void { ) void {
if (RC_TYPE == Refcount.none) return; if (RC_TYPE == Refcount.none) return;
@ -346,6 +346,10 @@ inline fn decref_ptr_to_refcount(
std.debug.print("| decrement {*}: ", .{refcount_ptr}); std.debug.print("| decrement {*}: ", .{refcount_ptr});
} }
// Due to RC alignmen tmust take into acount pointer size.
const ptr_width = @sizeOf(usize);
const alignment = @max(ptr_width, element_alignment);
// Ensure that the refcount is not whole program lifetime. // Ensure that the refcount is not whole program lifetime.
const refcount: isize = refcount_ptr[0]; const refcount: isize = refcount_ptr[0];
if (refcount != REFCOUNT_MAX_ISIZE) { if (refcount != REFCOUNT_MAX_ISIZE) {