language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 14:54:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

No phi node at all, just an conditional branch

Browse source
This commit is contained in:
Chad Stearns 2020-08-08 01:26:25 -04:00
parent 0f717ac45a
commit 4e906a5156
1 changed files with 76 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

36
compiler/gen/src/llvm/build.rs
View file

@ -1702,15 +1702,19 @@ fn list_join<'a, 'ctx, 'env>(
// inner_list_len > 0
let inner_list_comparison = list_is_not_empty(builder, ctx, inner_list_len);
let build_empty = || {
BasicValueEnum::PointerValue(
builder
.build_load(dest_elem_ptr_alloca, "load_dest_elem_ptr")
.into_pointer_value(),
)
};
let inner_list_non_empty_block =
ctx.append_basic_block(parent, "inner_list_non_empty");
let after_inner_list_non_empty_block =
ctx.append_basic_block(parent, "branchcont");
builder.build_conditional_branch(
inner_list_comparison,
inner_list_non_empty_block,
after_inner_list_non_empty_block,
);
builder.position_at_end(inner_list_non_empty_block);
let build_non_empty = || {
let inner_index_name = "#inner_index";
let inner_index_alloca =
builder.build_alloca(ctx.i64_type(), inner_index_name);
@ -1781,20 +1785,8 @@ fn list_join<'a, 'ctx, 'env>(
);
builder.position_at_end(after_inner_loop_bb);
inc_dest_elem_ptr
};
build_basic_phi2(
env,
parent,
inner_list_comparison,
build_non_empty,
build_empty,
BasicTypeEnum::PointerType(get_ptr_type(
&elem_type,
AddressSpace::Generic,
)),
);
builder.build_unconditional_branch(after_inner_list_non_empty_block);
builder.position_at_end(after_inner_list_non_empty_block);
}
// #index < outer_list_len