language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 21:39:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Make minimization work properly in the presence of unicode chars

Browse source
This commit is contained in:
Joshua Warner 2024-12-14 10:58:32 -08:00
parent 8b7ac512f8
commit 4fd18afce7
No known key found for this signature in database
GPG key ID: 89AD497003F93FDD
1 changed files with 20 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

28
crates/compiler/test_syntax/src/minimize.rs
View file

@ -23,14 +23,9 @@ pub fn print_minimizations(text: &str, kind: InputKind) {
loop {
let mut found = false;
for update in candidate_minimizations(s.clone()) {
let mut new_s = String::with_capacity(s.len());
let mut offset = 0;
for (start, end, replacement) in update.replacements.clone() {
new_s.push_str(&s[offset..start]);
new_s.push_str(&replacement);
offset = end;
}
new_s.push_str(&s[offset..]);
let Some(new_s) = make_replacements(&s, &update) else {
continue;
};
assert!(
new_s.len() < s.len(),
@ -58,6 +53,23 @@ pub fn print_minimizations(text: &str, kind: InputKind) {
println!("{}", s);
}
fn make_replacements(s: &str, update: &Update) -> Option<String> {
let mut new_s = String::with_capacity(s.len());
let mut offset = 0;
for (start, end, replacement) in update.replacements.clone() {
// check that start and end are not in the middle of a utf-8 character
if !s.is_char_boundary(start) || !s.is_char_boundary(end) {
return None;
}
new_s.push_str(&s[offset..start]);
new_s.push_str(&replacement);
offset = end;
}
new_s.push_str(&s[offset..]);
Some(new_s)
}
fn round_trip_once_and_extract_error(text: &str, kind: InputKind) -> Option<String> {
let input = kind.with_text(text);
let res = std::panic::catch_unwind(|| round_trip_once(input));