language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 22:09:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Smarter marks

Browse source
This commit is contained in:
Ayaz Hafiz 2022-04-28 10:24:27 -04:00 • committed by ayazhafiz
parent 2f1306afd1
commit 51c8702820
4 changed files with 16 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

20
compiler/constrain/src/expr.rs
View file

@ -15,7 +15,7 @@ use roc_collections::all::{HumanIndex, MutMap, SendMap};
use roc_module::ident::{Lowercase, TagName};
use roc_module::symbol::{ModuleId, Symbol};
use roc_region::all::{Loc, Region};
use roc_types::subs::{ExhaustiveMark, RedundantMark, Variable};
use roc_types::subs::Variable;
use roc_types::types::Type::{self, *};
use roc_types::types::{
AliasKind, AnnotationSource, Category, PReason, Reason, RecordField, TypeExtension,
@ -719,15 +719,6 @@ pub fn constrain_expr(
);
pattern_cons.push(cond_constraint);
// Mark the `when` as exhaustive initially. We'll refine this if the condition
// disagrees.
pattern_cons.push(constraints.store(
ExhaustiveMark::EXHAUSTIVE_TYPE,
exhaustive.0,
file!(),
line!(),
));
// Now check the condition against the type expected by the branches.
let sketched_rows = sketch_rows(real_cond_var, branches_region, branches);
let cond_matches_branches_constraint = constraints.exhaustive(
@ -1182,15 +1173,6 @@ fn constrain_when_branch_help(
delayed_is_open_constraints: Vec::new(),
};
// Mark the branch as non-redundant initially. We'll refine this during solving.
state.vars.push(when_branch.redundant.0);
state.constraints.push(constraints.store(
RedundantMark::NON_REDUNDANT_TYPE,
when_branch.redundant.0,
file!(),
line!(),
));
// TODO investigate for error messages, is it better to unify all branches with a variable,
// then unify that variable with the expectation?
for (i, loc_pattern) in when_branch.patterns.iter().enumerate() {