language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 19:58:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Address review comments

Browse source 
- Remove `num_args` call that wasn't supposed to be there
- Factor out shared value parser with non-trivial init
This commit is contained in:
David Smith 2023-05-14 20:30:27 -04:00
parent 003aacbf28
commit 54c130ca1a
No known key found for this signature in database
GPG key ID: 979D8D09D9570EED
1 changed files with 4 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/cli/src/lib.rs
View file

@ -143,6 +143,8 @@ pub fn build_app() -> Command {
.allow_hyphen_values(true)
.last(true);
let build_target_values_parser =
PossibleValuesParser::new(Target::iter().map(Into::<&'static str>::into));
let app = Command::new("roc")
.version(concatcp!(VERSION, "\n"))
.about("Run the given .roc file, if there are no compilation errors.\nYou can use one of the SUBCOMMANDS below to do something else!")
@ -162,12 +164,7 @@ pub fn build_app() -> Command {
.long(FLAG_TARGET)
.help("Choose a different target")
.default_value(Into::<&'static str>::into(Target::default()))
.value_parser(
PossibleValuesParser::new(
Target::iter().map(|target| {
Into::<&'static str>::into(target)
})
))
.value_parser(build_target_values_parser.clone())
.required(false),
)
.arg(
@ -283,7 +280,6 @@ pub fn build_app() -> Command {
.about("Generate documentation for a Roc package")
.arg(Arg::new(ROC_FILE)
.help("The package's main .roc file")
.num_args(0..0)
.value_parser(value_parser!(PathBuf))
.required(false)
.default_value(DEFAULT_ROC_FILENAME),
@ -325,12 +321,7 @@ pub fn build_app() -> Command {
.long(FLAG_TARGET)
.help("Choose a different target")
.default_value(Into::<&'static str>::into(Target::default()))
.value_parser(
PossibleValuesParser::new(
Target::iter().map(|target| {
Into::<&'static str>::into(target)
})
))
.value_parser(build_target_values_parser)
.required(false),
)
)