language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-04 12:18:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Generalize RecordAccess special-cases to include TupleAccess

Browse source
This commit is contained in:
Joshua Warner 2024-12-12 19:59:14 -08:00
parent d66f51db7b
commit 5a6e0f546b
No known key found for this signature in database
GPG key ID: 89AD497003F93FDD
5 changed files with 68 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/compiler/test_syntax/tests/test_snapshots.rs
View file

@ -316,6 +316,7 @@ mod test_snapshots {
pass/backpassing_bananza.expr,
pass/backpassing_in_parens_in_tuple.expr,
pass/bang_newline_double_accessor.expr,
pass/bangs_and_tuple_accessors.expr,
pass/basic_apply.expr,
pass/basic_docs.expr,
pass/basic_field.expr,
@ -715,7 +716,11 @@ mod test_snapshots {
// This is the current list as of writing.
// We should be driving these down to zero over time.
// Adding this protection in now to avoid accidentally adding more.
"all_the_bangs" => true,
"all_the_bangs" | "bangs_and_tuple_accessors" => {
// both of these result in:
// "a Expr::TrySuffix expression was not completely removed in desugar_value_def_suffixed"
true
}
// When adding new snapshot tests, strongly prefer fixing any canonicalization panics
// they may run into rather than adding them to this list.