language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-07-23 06:25:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Implement de-generalization for weakened let bindings

Browse source
This commit is contained in:
Ayaz Hafiz 2023-01-10 10:51:02 -06:00
parent cb18291aa8
commit 5ccedca093
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/compiler/solve/src/solve.rs
View file

@ -790,7 +790,16 @@ fn solve(
let_con.def_types,
);
pools.get_mut(next_rank).extend(pool_variables);
// If the let-binding can be generalized, introduce all variables at the next rank;
// those that persist at the next rank after rank-adjustment will be generalized.
//
// Otherwise, introduce all variables at the current rank; since none of them will
// end up at the next rank, none will be generalized.
if let_con.generalizable.0 {
pools.get_mut(next_rank).extend(pool_variables);
} else {
pools.get_mut(rank).extend(pool_variables);
}
debug_assert_eq!(
// Check that no variable ended up in a higher rank than the next rank.. that