language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 00:24:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Report when ability member binds >1 variable to parent

Browse source
This commit is contained in:
Ayaz Hafiz 2022-04-13 10:11:24 -04:00
parent a1c1dc1a9f
commit 5e1ab8225e
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 96 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

20
compiler/can/src/def.rs
View file

@ -491,6 +491,26 @@ pub fn canonicalize_defs<'a>(
bad_has_clauses = true;
}
if variables_bound_to_ability.len() > 1 {
// There is more than one variable bound to the member signature, so something like
// Eq has eq : a, b -> Bool | a has Eq, b has Eq
// We have no way of telling what type implements a particular instance of Eq in
// this case (a or b?), so disallow it.
let span_has_clauses =
Region::across_all(variables_bound_to_ability.iter().map(|v| &v.first_seen));
let bound_var_names = variables_bound_to_ability
.iter()
.map(|v| v.name.clone())
.collect();
env.problem(Problem::AbilityMemberMultipleBoundVars {
member: member_sym,
ability: loc_ability_name.value,
span_has_clauses,
bound_var_names,
});
bad_has_clauses = true;
}
if !variables_bound_to_other_abilities.is_empty() {
// Disallow variables bound to other abilities, for now.
for bad_variable in variables_bound_to_other_abilities.iter() {