language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 13:59:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fixed perf for incremented_children

Browse source
This commit is contained in:
J.Teeuwissen 2023-05-24 20:42:22 +02:00
parent b049b29613
commit 62446b7c60
No known key found for this signature in database
GPG key ID: DB5F7A1ED8D478AD
1 changed files with 29 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

40
crates/compiler/mono/src/drop_specialization.rs
View file

@ -393,20 +393,7 @@ fn specialize_drops_stmt<'a, 'i>(
// dec a // dec a
// dec b // dec b
// Collect all children that were incremented and make sure that one increment remains in the environment afterwards. if environment.pop_incremented(symbol) {
// To prevent
// let a = index b; inc a; dec b; ...; dec a
// from being translated to
// let a = index b; dec b
// As a might get dropped as a result of the decrement of b.
let mut incremented_children = environment
.get_children(symbol)
.iter()
.copied()
.filter_map(|child| environment.pop_incremented(&child).then_some(child))
.collect::<MutSet<_>>();
let updated_stmt = if environment.pop_incremented(symbol) {
// This decremented symbol was incremented before, so we can remove it. // This decremented symbol was incremented before, so we can remove it.
specialize_drops_stmt( specialize_drops_stmt(
arena, arena,
@ -416,11 +403,32 @@ fn specialize_drops_stmt<'a, 'i>(
continuation, continuation,
) )
} else { } else {
// Collect all children (recursively) that were incremented and make sure that one increment remains in the environment afterwards.
// To prevent
// let a = index b; inc a; dec b; ...; dec a
// from being translated to
// let a = index b; dec b
// As a might get dropped as a result of the decrement of b.
let mut incremented_children = {
let mut todo_children = bumpalo::vec![in &arena; *symbol];
let mut incremented_children = MutSet::default();
while let Some(child) = todo_children.pop() {
if environment.pop_incremented(&child) {
incremented_children.insert(child);
} else {
todo_children.extend(environment.get_children(&child));
}
}
incremented_children
};
// This decremented symbol was not incremented before, perhaps the children were. // This decremented symbol was not incremented before, perhaps the children were.
let in_layout = environment.get_symbol_layout(symbol); let in_layout = environment.get_symbol_layout(symbol);
let runtime_layout = layout_interner.runtime_representation(*in_layout); let runtime_layout = layout_interner.runtime_representation(*in_layout);
match runtime_layout.repr { let updated_stmt = match runtime_layout.repr {
// Layout has children, try to inline them. // Layout has children, try to inline them.
LayoutRepr::Struct(field_layouts) => specialize_struct( LayoutRepr::Struct(field_layouts) => specialize_struct(
arena, arena,
@ -474,7 +482,6 @@ fn specialize_drops_stmt<'a, 'i>(
// No children, keep decrementing the symbol. // No children, keep decrementing the symbol.
arena.alloc(Stmt::Refcounting(ModifyRc::Dec(*symbol), new_continuation)) arena.alloc(Stmt::Refcounting(ModifyRc::Dec(*symbol), new_continuation))
} }
}
}; };
// Add back the increments for the children to the environment. // Add back the increments for the children to the environment.
@ -484,6 +491,7 @@ fn specialize_drops_stmt<'a, 'i>(
updated_stmt updated_stmt
} }
}
ModifyRc::DecRef(_) => { ModifyRc::DecRef(_) => {
// Inlining has no point, since it doesn't decrement it's children // Inlining has no point, since it doesn't decrement it's children
arena.alloc(Stmt::Refcounting( arena.alloc(Stmt::Refcounting(