language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-07-24 15:03:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

snapshot subs to avoid cloning them

Browse source
This commit is contained in:
Brendan Hansknecht 2023-04-07 17:04:29 -07:00
parent 90f4885f4b
commit 62fcc71be3
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/compiler/solve/src/solve.rs
View file

@ -1784,19 +1784,19 @@ fn solve(
*type_index,
);
let snapshot = subs.snapshot();
if let Success { .. } = unify(
// TODO: if we don't clone and a later branch matches, we will get a failure in alias analysis.
// That said, I assume cloning is expensive and should be avoided.
&mut UEnv::new(&mut subs.clone()),
&mut UEnv::new(subs),
actual,
Variable::LIST_U8,
Mode::EQ,
Polarity::OF_VALUE,
) {
// List U8 always valid.
subs.rollback_to(snapshot);
state
} else if let Success { .. } = unify(
&mut UEnv::new(&mut subs.clone()),
&mut UEnv::new(subs),
actual,
Variable::STR,
Mode::EQ,
@ -1807,6 +1807,7 @@ fn solve(
todo!("add type error due to not being a utf8 string");
}
subs.rollback_to(snapshot);
state
} else {
// Unexpected type.
@ -1819,6 +1820,7 @@ fn solve(
// );
// problems.push(problem);
// subs.rollback_to(snapshot);
// state
}
}