language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 14:54:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

remove giesch/todo tags, add List.drop doc

Browse source
This commit is contained in:
Dan Knutson 2021-10-03 09:59:32 -05:00
parent 700ab20a8c
commit 65821d6a9f
3 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/builtins/bitcode/src/list.zig
View file

@ -833,8 +833,6 @@ pub fn listDrop(
}
}
// GIESCH do a uniqueness check, and reuse the same array if possible
// GIESCH figure out where to specify uniqueness of output, update builtins readme
pub fn listDropAt(
list: RocList,
alignment: u32,
@ -846,7 +844,6 @@ pub fn listDropAt(
const size = list.len();
if (drop_index >= size) {
// GIESCH should this still copy/reallocate if non-unique?
return list;
}
@ -866,7 +863,6 @@ pub fn listDropAt(
const tail_size = (size - drop_index - 1) * element_width;
@memcpy(tail_target, tail_source, tail_size);
// GIESCH what's the difference between this and Dec?
utils.decref(list.bytes, size * element_width, alignment);
return output;