language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Use LayoutRepr directly when possible

Browse source
This commit is contained in:
Ayaz Hafiz 2023-05-10 15:28:11 -05:00
parent 7b2d149deb
commit 6714a6fd92
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
3 changed files with 9 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/compiler/gen_llvm/src/llvm/refcounting.rs
View file

@ -19,8 +19,7 @@ use inkwell::{AddressSpace, IntPredicate};
use roc_module::symbol::Interns;
use roc_module::symbol::Symbol;
use roc_mono::layout::{
Builtin, InLayout, Layout, LayoutIds, LayoutInterner, LayoutRepr, STLayoutInterner,
SemanticRepr, UnionLayout,
Builtin, InLayout, Layout, LayoutIds, LayoutInterner, LayoutRepr, STLayoutInterner, UnionLayout,
};
use super::build::{cast_if_necessary_for_opaque_recursive_pointers, load_roc_value, FunctionSpec};
@ -805,11 +804,7 @@ fn modify_refcount_str_help<'a, 'ctx>(
let parent = fn_val;
let str_type = zig_str_type(env);
// TODO(deref-layout)
let str_wrapper = if (Layout {
repr: LayoutRepr::Builtin(Builtin::Str),
semantic: SemanticRepr::None,
})
let str_wrapper = if LayoutRepr::Builtin(Builtin::Str)
.is_passed_by_reference(layout_interner, env.target_info)
{
env.builder

6
crates/compiler/gen_wasm/src/low_level.rs
View file

@ -404,11 +404,7 @@ impl<'a> LowLevelCall<'a> {
if l2.repr == backend.layout_interner.get(list_elem).repr =>
{
let list_offset = 0;
// TODO(deref-layout)
let elem_offset = Layout {
repr: LayoutRepr::Builtin(Builtin::List(list_elem)),
semantic: SemanticRepr::None,
}
let elem_offset = LayoutRepr::Builtin(Builtin::List(list_elem))
.stack_size(backend.layout_interner, TARGET_INFO);
(list_offset, elem_offset, f2)
}

10
crates/compiler/mono/src/code_gen_help/refcount.rs
View file

@ -12,8 +12,8 @@ use crate::ir::{
BranchInfo, Call, CallType, Expr, JoinPointId, Literal, ModifyRc, Param, Stmt, UpdateModeId,
};
use crate::layout::{
Builtin, InLayout, Layout, LayoutInterner, LayoutRepr, STLayoutInterner, SemanticRepr,
TagIdIntType, UnionLayout,
Builtin, InLayout, Layout, LayoutInterner, LayoutRepr, STLayoutInterner, TagIdIntType,
UnionLayout,
};
use super::{CodeGenHelp, Context, HelperOp};
@ -1483,11 +1483,7 @@ fn refcount_union_rec<'a>(
};
let rc_structure_stmt = {
// TODO(deref-layout)
let alignment = Layout {
repr: LayoutRepr::Union(union_layout),
semantic: SemanticRepr::None,
}
let alignment = LayoutRepr::Union(union_layout)
.allocation_alignment_bytes(layout_interner, root.target_info);
let ret_stmt = rc_return_stmt(root, ident_ids, ctx);