language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-01 07:41:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

simplify recursive case

Browse source
This commit is contained in:
Folkert 2021-01-22 13:18:27 +01:00
parent 155c9fd9b0
commit 690f3ee5c9
1 changed files with 1 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

21
compiler/gen/src/llvm/refcounting.rs
View file

@ -1000,8 +1000,7 @@ fn build_rec_union_help<'a, 'ctx, 'env>(
// recursively decrement the field
let call_name = pick("recursive_tag_increment", "recursive_tag_decrement");
let call_mode = mode_to_call_mode(fn_val, mode);
recursive_call_help(env, fn_val, call_mode, recursive_field_ptr, call_name);
call_help(env, fn_val, mode, recursive_field_ptr, call_name);
} else if field_layout.contains_refcounted() {
// TODO this loads the whole field onto the stack;
// that's wasteful if e.g. the field is a big record, where only
@ -1096,24 +1095,6 @@ fn call_help<'a, 'ctx, 'env>(
call.set_call_convention(FAST_CALL_CONV);
}
fn recursive_call_help<'a, 'ctx, 'env>(
env: &Env<'a, 'ctx, 'env>,
function: FunctionValue<'ctx>,
mode: CallMode,
value: BasicValueEnum<'ctx>,
call_name: &str,
) {
let call = match mode {
CallMode::Inc(_, inc_amount) => {
env.builder
.build_call(function, &[value, inc_amount.into()], call_name)
}
CallMode::Dec => env.builder.build_call(function, &[value], call_name),
};
call.set_call_convention(FAST_CALL_CONV);
}
fn modify_refcount_union<'a, 'ctx, 'env>(
env: &Env<'a, 'ctx, 'env>,
layout_ids: &mut LayoutIds<'a>,