From 702092859ee60b70a308571a8f51b4c448dfaab7 Mon Sep 17 00:00:00 2001
From: Agus Zubiaga <hi@aguz.me>
Date: Mon, 1 Jul 2024 18:06:41 -0300
Subject: [PATCH] Add pattern type for module params

---
 crates/compiler/can/src/module.rs          | 3 +--
 crates/compiler/parse/src/pattern.rs       | 1 +
 crates/reporting/src/error/canonicalize.rs | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/crates/compiler/can/src/module.rs b/crates/compiler/can/src/module.rs
index bd468d224a..bd602f8516 100644
--- a/crates/compiler/can/src/module.rs
+++ b/crates/compiler/can/src/module.rs
@@ -401,8 +401,7 @@ pub fn canonicalize_module_defs<'a>(
                 var_store,
                 &mut scope,
                 &mut output,
-                // todo(agus): custom type for param
-                PatternType::FunctionArg,
+                PatternType::ModuleParams,
                 &pattern.value,
                 pattern.region,
                 PermitShadows(false),
diff --git a/crates/compiler/parse/src/pattern.rs b/crates/compiler/parse/src/pattern.rs
index a9dbf051d7..1f3f9bfe5f 100644
--- a/crates/compiler/parse/src/pattern.rs
+++ b/crates/compiler/parse/src/pattern.rs
@@ -25,6 +25,7 @@ pub enum PatternType {
     DefExpr,
     FunctionArg,
     WhenBranch,
+    ModuleParams,
 }
 
 pub fn closure_param<'a>() -> impl Parser<'a, Loc<Pattern<'a>>, EPattern<'a>> {
diff --git a/crates/reporting/src/error/canonicalize.rs b/crates/reporting/src/error/canonicalize.rs
index 41957cdf3f..4d7bf9774b 100644
--- a/crates/reporting/src/error/canonicalize.rs
+++ b/crates/reporting/src/error/canonicalize.rs
@@ -390,6 +390,7 @@ pub fn can_problem<'b>(
                 TopLevelDef => "a top-level definition:",
                 DefExpr => "a value definition:",
                 FunctionArg => "function arguments:",
+                ModuleParams => "module params:",
                 WhenBranch => unreachable!("all patterns are allowed in a When"),
             };