language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 14:24:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

step 1: Deriv works and has no valgrind problems

Browse source
This commit is contained in:
Folkert 2022-03-26 17:56:56 +01:00
parent baec1c2de3
commit 71c11784a0
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
6 changed files with 34 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

19
compiler/gen_llvm/src/llvm/build_str.rs
View file

@ -128,14 +128,10 @@ pub fn str_concat<'a, 'ctx, 'env>(
str2_symbol: Symbol,
) -> BasicValueEnum<'ctx> {
// swap the arguments; second argument comes before the second in the output string
let str1_c_abi = str_symbol_to_c_abi(env, scope, str1_symbol);
let str2_c_abi = str_symbol_to_c_abi(env, scope, str2_symbol);
let str1 = load_symbol(scope, &str1_symbol);
let str2 = load_symbol(scope, &str2_symbol);
call_str_bitcode_fn(
env,
&[str1_c_abi.into(), str2_c_abi.into()],
bitcode::STR_CONCAT,
)
call_str_bitcode_fn(env, &[str1, str2], bitcode::STR_CONCAT)
}
/// Str.join : List Str, Str -> Str
@ -398,12 +394,5 @@ pub fn str_equal<'a, 'ctx, 'env>(
value1: BasicValueEnum<'ctx>,
value2: BasicValueEnum<'ctx>,
) -> BasicValueEnum<'ctx> {
let str1_i128 = str_to_c_abi(env, value1);
let str2_i128 = str_to_c_abi(env, value2);
call_bitcode_fn(
env,
&[str1_i128.into(), str2_i128.into()],
bitcode::STR_EQUAL,
)
call_bitcode_fn(env, &[value1, value2], bitcode::STR_EQUAL)
}