language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 14:24:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix lifetime errors due to interner

Browse source 
In the llvm backend, there are the lifetimes `'a` (lifetime of the
global arena) and `'ctx` (lifetime of constructed LLVM values). `'a`
lives longer than `'ctx`, but the compiler didn't enforce this until
the layout interner was introduced, for some reason. We have to make
sure that containers of lifetime `'a` have no `'ctx` references.
This commit is contained in:
Ayaz Hafiz 2022-12-29 11:38:34 -06:00
parent 512a1721ae
commit 759f8d86af
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
6 changed files with 54 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/repl_expect/src/run.rs
View file

@ -716,7 +716,7 @@ pub fn expect_mono_module_to_dylib<'a>(
toplevel_expects,
procedures,
interns,
layout_interner,
mut layout_interner,
..
} = loaded;
@ -735,7 +735,6 @@ pub fn expect_mono_module_to_dylib<'a>(
// Compile and add all the Procs before adding main
let env = roc_gen_llvm::llvm::build::Env {
arena,
layout_interner: &layout_interner,
builder: &builder,
dibuilder: &dibuilder,
compile_unit: &compile_unit,
@ -760,8 +759,9 @@ pub fn expect_mono_module_to_dylib<'a>(
let expect_names = roc_gen_llvm::llvm::build::build_procedures_expose_expects(
&env,
&mut layout_interner,
opt_level,
&expect_symbols,
expect_symbols.into_bump_slice(),
procedures,
);