language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-23 03:52:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Report errors for identifiers not bound in all patterns of a branch

Browse source
This commit is contained in:
Ayaz Hafiz 2022-07-21 12:15:05 -04:00
parent ce8b50caea
commit 78dc82867a
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
6 changed files with 154 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

34
crates/compiler/constrain/src/expr.rs
View file

@ -1843,24 +1843,28 @@ fn constrain_when_branch_help(
if i == 0 {
state.headers.extend(partial_state.headers);
} else {
debug_assert!(
state.headers.keys().all(|sym| partial_state.headers.contains_key(sym)) &&
partial_state.headers.keys().all(|sym| state.headers.contains_key(sym)),
"State and partial state headers differ in bound symbols, should have been caught in canonicalization");
// Make sure the bound variables in the patterns on the same branch agree in their types.
for (sym, typ1) in state.headers.iter() {
let typ2 = partial_state
.headers
.get(sym)
.expect("bound variable in branch not bound in pattern!");
if let Some(typ2) = partial_state.headers.get(sym) {
state.constraints.push(constraints.equal_types(
typ1.value.clone(),
Expected::NoExpectation(typ2.value.clone()),
Category::When,
typ2.region,
));
}
state.constraints.push(constraints.equal_types(
typ1.value.clone(),
Expected::NoExpectation(typ2.value.clone()),
Category::When,
typ2.region,
));
// If the pattern doesn't bind all symbols introduced in the branch we'll have
// reported a canonicalization error, but still might reach here; that's okay.
}
// Add any variables this pattern binds that the other patterns don't bind.
// This will already have been reported as an error, but we still might be able to
// solve their types.
for (sym, ty) in partial_state.headers {
if !state.headers.contains_key(&sym) {
state.headers.insert(sym, ty);
}
}
}
}