language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-30 23:31:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Refactor SymbolStorage local_id code, and copy_memory

Browse source 
SymbolStorage had some rather ad-hoc methods for extracting pieces of data.
This change makes that more intentional and organised.

Also cleaned up the API for the related function copy_memory,
as it had lots of positional arguments with the same types.
Created a struct for this just to name them and make the code clearer.
This commit is contained in:
Brian Carroll 2021-10-02 22:07:12 +01:00
parent 6aed70978d
commit 79a4f2bbf7
3 changed files with 217 additions and 183 deletions
Download patch file Download diff file Expand all files Collapse all files

50
compiler/gen_wasm/src/lib.rs
View file

@ -121,7 +121,7 @@ fn encode_alignment(bytes: u32) -> u32 {
}
}
pub struct MemoryCopy {
pub struct CopyMemoryConfig {
from_ptr: LocalId,
from_offset: u32,
to_ptr: LocalId,
@ -130,31 +130,29 @@ pub struct MemoryCopy {
alignment_bytes: u32,
}
impl MemoryCopy {
pub fn generate(&self, instructions: &mut Vec<Instruction>) {
let alignment_flag = encode_alignment(self.alignment_bytes);
let mut i = 0;
while self.size - i >= 8 {
instructions.push(GetLocal(self.to_ptr.0));
instructions.push(GetLocal(self.from_ptr.0));
instructions.push(I64Load(alignment_flag, i + self.from_offset));
instructions.push(I64Store(alignment_flag, i + self.to_offset));
i += 8;
}
if self.size - i >= 4 {
instructions.push(GetLocal(self.to_ptr.0));
instructions.push(GetLocal(self.from_ptr.0));
instructions.push(I32Load(alignment_flag, i + self.from_offset));
instructions.push(I32Store(alignment_flag, i + self.to_offset));
i += 4;
}
while self.size - i > 0 {
instructions.push(GetLocal(self.to_ptr.0));
instructions.push(GetLocal(self.from_ptr.0));
instructions.push(I32Load8U(alignment_flag, i + self.from_offset));
instructions.push(I32Store8(alignment_flag, i + self.to_offset));
i += 1;
}
pub fn copy_memory(instructions: &mut Vec<Instruction>, config: CopyMemoryConfig) {
let alignment_flag = encode_alignment(config.alignment_bytes);
let mut i = 0;
while config.size - i >= 8 {
instructions.push(GetLocal(config.to_ptr.0));
instructions.push(GetLocal(config.from_ptr.0));
instructions.push(I64Load(alignment_flag, i + config.from_offset));
instructions.push(I64Store(alignment_flag, i + config.to_offset));
i += 8;
}
if config.size - i >= 4 {
instructions.push(GetLocal(config.to_ptr.0));
instructions.push(GetLocal(config.from_ptr.0));
instructions.push(I32Load(alignment_flag, i + config.from_offset));
instructions.push(I32Store(alignment_flag, i + config.to_offset));
i += 4;
}
while config.size - i > 0 {
instructions.push(GetLocal(config.to_ptr.0));
instructions.push(GetLocal(config.from_ptr.0));
instructions.push(I32Load8U(alignment_flag, i + config.from_offset));
instructions.push(I32Store8(alignment_flag, i + config.to_offset));
i += 1;
}
}