language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 22:09:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

make tag allocas at the function entry point block

Browse source
This commit is contained in:
Folkert 2022-01-23 00:21:18 +01:00
parent 390a50c537
commit 7baec2b201
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
compiler/gen_llvm/src/llvm/build.rs
View file

@ -1474,10 +1474,17 @@ fn build_wrapped_tag<'a, 'ctx, 'env>(
pub fn tag_alloca<'a, 'ctx, 'env>(
env: &Env<'a, 'ctx, 'env>,
type_: BasicTypeEnum<'ctx>,
basic_type: BasicTypeEnum<'ctx>,
name: &str,
) -> PointerValue<'ctx> {
let result_alloca = env.builder.build_alloca(type_, name);
// let result_alloca = env.builder.build_alloca(basic_type, name);
let parent = env
.builder
.get_insert_block()
.unwrap()
.get_parent()
.unwrap();
let result_alloca = create_entry_block_alloca(env, parent, basic_type, name);
// Initialize all memory of the alloca. This _should_ not be required, but currently
// LLVM can access uninitialized memory after applying some optimizations. Hopefully
@ -1496,7 +1503,7 @@ pub fn tag_alloca<'a, 'ctx, 'env>(
// After inlining, those checks are combined. That means that even if the tag is Err,
// a check is done on the "string" to see if it is big or small, which will touch the
// uninitialized memory.
let all_zeros = type_.const_zero();
let all_zeros = basic_type.const_zero();
env.builder.build_store(result_alloca, all_zeros);
result_alloca