language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-12-23 08:48:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix memory leak

Browse source
This commit is contained in:
Richard Feldman 2025-11-17 20:15:40 -05:00
parent 414918dcd0
commit 7ea7123aa7
No known key found for this signature in database
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/snapshot_tool/main.zig
View file

@ -1201,8 +1201,15 @@ fn processSnapshotContent(
can_ir.debugAssertArraysInSync();
// Compute dependency-based evaluation order if not already set
// (canonicalizeFile sets it, but other paths like .statement don't)
if (can_ir.evaluation_order == null) {
// Skip for .file/.package/.platform/.app tests because canonicalizeAndTypeCheckModule
// will call canonicalizeFile which sets it. Only do this for .expr/.statement which
// don't call canonicalizeFile.
const needs_evaluation_order = switch (content.meta.node_type) {
.expr, .statement => true,
.file, .package, .platform, .app, .snippet, .repl, .header => false,
};
if (needs_evaluation_order and can_ir.evaluation_order == null) {
const DependencyGraph = @import("can").DependencyGraph;
var graph = try DependencyGraph.buildDependencyGraph(
can_ir,
@ -1212,7 +1219,9 @@ fn processSnapshotContent(
defer graph.deinit();
const eval_order = try DependencyGraph.computeSCCs(&graph, allocator);
const eval_order_ptr = try allocator.create(DependencyGraph.EvaluationOrder);
// IMPORTANT: Use can_ir.gpa here, not allocator, because ModuleEnv.deinit()
// will free this with self.gpa. They must match to avoid memory leaks.
const eval_order_ptr = try can_ir.gpa.create(DependencyGraph.EvaluationOrder);
eval_order_ptr.* = eval_order;
can_ir.evaluation_order = eval_order_ptr;
}