language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-07-24 06:55:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Get rid of unneeded unsafe code and explain max_rank adjustment

Browse source
This commit is contained in:
Ayaz Hafiz 2023-01-11 14:20:19 -06:00
parent ddda00036e
commit 7febddd1ea
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/compiler/solve/src/solve.rs
View file

@ -3615,15 +3615,14 @@ fn adjust_rank(
let desc_mark = subs.get_mark_unchecked(var);
if desc_mark == young_mark {
let content = {
let ptr = subs.get_content_unchecked(var) as *const _;
unsafe { &*ptr }
};
let content = *subs.get_content_unchecked(var);
// Mark the variable as visited before adjusting content, as it may be cyclic.
subs.set_mark_unchecked(var, visit_mark);
let max_rank = adjust_rank_content(subs, young_mark, visit_mark, group_rank, content);
// Adjust the nested types' ranks, making sure that no nested unbound type variable is at a
// higher rank than the group rank this `var` is at
let max_rank = adjust_rank_content(subs, young_mark, visit_mark, group_rank, &content);
subs.set_rank_unchecked(var, max_rank);
subs.set_mark_unchecked(var, visit_mark);