language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 03:42:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Remove stale comments

Browse source
This commit is contained in:
Ayaz Hafiz 2022-07-12 15:00:56 -04:00
parent 6413000579
commit 7ff180c1a5
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
2 changed files with 7 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/compiler/derive/src/lib.rs
View file

@ -102,10 +102,6 @@ impl DerivedModule {
let ident_id = if cfg!(debug_assertions) || cfg!(feature = "debug-derived-symbols") {
let debug_name = key.debug_name();
// debug_assert!(
// self.derived_ident_ids.get_id(&debug_name).is_none(),
// "duplicate debug name for different derive key"
// );
let ident_id = self.derived_ident_ids.get_or_insert(&debug_name);
// This is expensive, but yields much better symbols when debugging.
@ -114,7 +110,6 @@ impl DerivedModule {
ident_id
} else {
// TODO this is WRONG when we're re-instantiating the derived impl
self.derived_ident_ids.gen_unique()
};

31
crates/compiler/solve/src/solve.rs
View file

@ -2157,31 +2157,14 @@ fn make_specialization_decision(subs: &Subs, var: Variable) -> SpecializeDecisio
// This is a structural type, find the name of the derived ability function it
// should use.
match roc_derive_key::Derived::encoding(subs, var) {
Ok(derived) => {
match derived {
roc_derive_key::Derived::Immediate(_) => {
todo!("deal with lambda set extraction from immediates")
}
roc_derive_key::Derived::Key(derive_key) => {
SpecializeDecision::Specialize(Derived(derive_key))
}
Ok(derived) => match derived {
roc_derive_key::Derived::Immediate(_) => {
todo!("deal with lambda set extraction from immediates")
}
// let specialization_symbol_slice =
// UnionLabels::insert_into_subs(subs, vec![(specialization_symbol, vec![])]);
// let lambda_set_for_derived = subs.fresh(Descriptor {
// content: LambdaSet(subs::LambdaSet {
// solved: specialization_symbol_slice,
// recursion_var: OptVariable::NONE,
// unspecialized: SubsSlice::default(),
// }),
// rank: target_rank,
// mark: Mark::NONE,
// copy: OptVariable::NONE,
// });
// specialized_to_unify_with.push(lambda_set_for_derived);
}
roc_derive_key::Derived::Key(derive_key) => {
SpecializeDecision::Specialize(Derived(derive_key))
}
},
Err(DeriveError::UnboundVar) => {
// not specialized yet, but that also means that it can't possibly be derivable
// at this point?