language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 14:54:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Merge pull request #2361 from rtfeldman/cleanup_builtins_Num.minmaxI128

Browse source 
Remove leftover TODOs from #2354
This commit is contained in:
Richard Feldman 2022-01-20 18:21:29 -05:00 • committed by GitHub
commit 83f12b6e53
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/can/src/builtins.rs
View file

@ -1453,7 +1453,6 @@ fn num_max_u64(symbol: Symbol, var_store: &mut VarStore) -> Def {
fn num_min_i128(symbol: Symbol, var_store: &mut VarStore) -> Def { fn num_min_i128(symbol: Symbol, var_store: &mut VarStore) -> Def {
let int_var = var_store.fresh(); let int_var = var_store.fresh();
let int_precision_var = var_store.fresh(); let int_precision_var = var_store.fresh();
// TODO: or `i128::MIN.into()` ?
let body = int::<i128>(int_var, int_precision_var, i128::MIN); let body = int::<i128>(int_var, int_precision_var, i128::MIN);
let std = roc_builtins::std::types(); let std = roc_builtins::std::types();
@ -1469,7 +1468,6 @@ fn num_min_i128(symbol: Symbol, var_store: &mut VarStore) -> Def {
}; };
Def { Def {
// TODO: or `None` ?
annotation: Some(annotation), annotation: Some(annotation),
expr_var: int_var, expr_var: int_var,
loc_expr: Loc::at_zero(body), loc_expr: Loc::at_zero(body),