language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 21:39:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

choose a different jump placeholder that fits in 27 bits

Browse source
This commit is contained in:
Folkert 2023-09-14 18:14:33 +02:00
parent 84367b1a08
commit 8a9126b024
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/compiler/gen_dev/src/generic64/mod.rs
View file

@ -30,6 +30,9 @@ use storage::{RegStorage, StorageManager};
// TODO: on all number functions double check and deal with over/underflow. // TODO: on all number functions double check and deal with over/underflow.
// NOTE: must fit in 27 bits and aligned to 4 for aarch64
const JUMP_PLACEHOLDER: i32 = 0x0011_1100;
#[derive(Debug, Clone, Copy)] #[derive(Debug, Clone, Copy)]
pub enum RegisterWidth { pub enum RegisterWidth {
W8, W8,
@ -1070,7 +1073,7 @@ impl<
// Build unconditional jump to the end of this switch. // Build unconditional jump to the end of this switch.
// Since we don't know the offset yet, set it to 0 and overwrite later. // Since we don't know the offset yet, set it to 0 and overwrite later.
let jmp_location = self.buf.len(); let jmp_location = self.buf.len();
let jmp_offset = ASM::jmp_imm32(&mut self.buf, 0x1234_5678); let jmp_offset = ASM::jmp_imm32(&mut self.buf, JUMP_PLACEHOLDER);
ret_jumps.push((jmp_location, jmp_offset)); ret_jumps.push((jmp_location, jmp_offset));
// Overwrite the original jne with the correct offset. // Overwrite the original jne with the correct offset.
@ -1162,7 +1165,7 @@ impl<
.setup_jump(self.layout_interner, &mut self.buf, id, args, arg_layouts); .setup_jump(self.layout_interner, &mut self.buf, id, args, arg_layouts);
let jmp_location = self.buf.len(); let jmp_location = self.buf.len();
let start_offset = ASM::jmp_imm32(&mut self.buf, 0x1234_5678); let start_offset = ASM::jmp_imm32(&mut self.buf, JUMP_PLACEHOLDER);
if let Some(vec) = self.join_map.get_mut(id) { if let Some(vec) = self.join_map.get_mut(id) {
vec.push((jmp_location as u64, start_offset as u64)) vec.push((jmp_location as u64, start_offset as u64))
@ -4342,7 +4345,7 @@ impl<
) )
} }
let inst_loc = self.buf.len() as u64; let inst_loc = self.buf.len() as u64;
let offset = ASM::jmp_imm32(&mut self.buf, 0x1234_5678) as u64; let offset = ASM::jmp_imm32(&mut self.buf, JUMP_PLACEHOLDER) as u64;
self.relocs.push(Relocation::JmpToReturn { self.relocs.push(Relocation::JmpToReturn {
inst_loc, inst_loc,
inst_size: self.buf.len() as u64 - inst_loc, inst_size: self.buf.len() as u64 - inst_loc,