language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 08:34:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

pass small non-recursive tag unions via registers (like records)

Browse source
This commit is contained in:
Folkert 2023-10-02 19:51:37 +02:00
parent 68dc7108bf
commit 905dc8cd59
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 2 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

22
crates/compiler/gen_dev/src/generic64/aarch64.rs
View file

@ -793,7 +793,7 @@ impl AArch64CallLoadArgs {
sym, sym,
lambda_set.runtime_representation(), lambda_set.runtime_representation(),
), ),
LayoutRepr::Struct { .. } => { LayoutRepr::Struct { .. } | LayoutRepr::Union(UnionLayout::NonRecursive(_)) => {
if stack_size <= 8 { if stack_size <= 8 {
self.load_arg_general_64bit( self.load_arg_general_64bit(
buf, buf,
@ -814,11 +814,6 @@ impl AArch64CallLoadArgs {
unreachable!("covered by an earlier branch") unreachable!("covered by an earlier branch")
} }
} }
LayoutRepr::Union(UnionLayout::NonRecursive(_)) => {
// for now, just also store this on the stack
storage_manager.complex_stack_arg(&sym, self.argument_offset, stack_size);
self.argument_offset += stack_size as i32;
}
_ => { _ => {
todo!( todo!(
"Loading args with layout {:?}", "Loading args with layout {:?}",
@ -979,7 +974,7 @@ impl AArch64CallStoreArgs {
sym, sym,
lambda_set.runtime_representation(), lambda_set.runtime_representation(),
), ),
LayoutRepr::Struct { .. } => { LayoutRepr::Struct { .. } | LayoutRepr::Union(UnionLayout::NonRecursive(_)) => {
let stack_size = layout_interner.stack_size(in_layout); let stack_size = layout_interner.stack_size(in_layout);
if stack_size <= 8 { if stack_size <= 8 {
self.store_arg_64bit(buf, storage_manager, sym); self.store_arg_64bit(buf, storage_manager, sym);
@ -989,19 +984,6 @@ impl AArch64CallStoreArgs {
unreachable!("covered by earlier branch"); unreachable!("covered by earlier branch");
} }
} }
LayoutRepr::Union(UnionLayout::NonRecursive(_)) => {
let stack_offset = self.tmp_stack_offset;
let size = copy_symbol_to_stack_offset::<CC>(
buf,
storage_manager,
sym,
tmp_reg,
stack_offset,
);
self.tmp_stack_offset += size as i32;
}
_ => { _ => {
todo!( todo!(
"calling with arg type, {:?}", "calling with arg type, {:?}",