language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Capture import params location for better errors

Browse source
This commit is contained in:
Agus Zubiaga 2024-07-01 18:03:42 -03:00
parent f0fe0a3ea6
commit 90c7745989
No known key found for this signature in database
6 changed files with 24 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/compiler/can/src/def.rs
View file

@ -3155,13 +3155,14 @@ fn to_pending_value_def<'a>(
let params = module_import.params.and_then(|params| {
let name_str = name_with_alias.as_str();
// todo(agus): params specific loc
match scope.introduce_str(format!("#{name_str}").as_str(), region) {
let params_region = params.params.region;
match scope.introduce_str(format!("#{name_str}").as_str(), params_region) {
Ok(sym) => {
params_sym = Some(sym);
let loc_pattern = Loc::at(region, Pattern::Identifier(sym));
Some((sym, loc_pattern, params.params))
let loc_pattern = Loc::at(params_region, Pattern::Identifier(sym));
Some((sym, loc_pattern, params.params.value))
},
Err(_) => {
// Ignore conflict, it will be handled as a duplicate import