language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-01 19:02:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

correct dropping of return pointer from exposed functions

Browse source
This commit is contained in:
Brendan Hansknecht 2022-07-09 09:18:22 -07:00
parent 856b38a958
commit 9248e1853b
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/compiler/gen_llvm/src/llvm/build.rs
View file

@ -3629,7 +3629,11 @@ fn expose_function_to_host_help_c_abi_v2<'a, 'ctx, 'env>(
let (params, param_types) = match (&roc_return, &cc_return) {
// Drop the "return pointer" if it exists on the roc function
// and the c function does not return via pointer
(RocReturn::ByPointer, CCReturn::Return) => (&params[..], &param_types[1..]),
(RocReturn::ByPointer, CCReturn::Return) => {
// Roc current puts the return pointer at the end of the argument list.
// As such, we drop the last element here instead of the first.
(&params[..], &param_types[..param_types.len() - 1])
}
// Drop the return pointer the other way, if the C function returns by pointer but Roc
// doesn't
(RocReturn::Return, CCReturn::ByPointer) => (&params[1..], &param_types[..]),