language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-02 16:21:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Weaken variables bound to when expressions

Browse source
This commit is contained in:
Ayaz Hafiz 2023-01-11 17:10:59 -06:00
parent a2f04d1fa3
commit 9462f44bb7
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/compiler/constrain/src/expr.rs
View file

@ -3829,11 +3829,11 @@ fn is_generalizable_expr(mut expr: &Expr) -> bool {
| Str(_) | Str(_)
| List { .. } | List { .. }
| SingleQuote(_, _, _, _) | SingleQuote(_, _, _, _)
| When { .. }
=> return false, => return false,
// TODO(weakening) // TODO(weakening)
| Var(_, _) | Var(_, _)
| AbilityMember(_, _, _) | AbilityMember(_, _, _)
| When { .. }
| If { .. } | If { .. }
| LetRec(_, _, _) | LetRec(_, _, _)
| LetNonRec(_, _) | LetNonRec(_, _)

10
crates/compiler/solve/tests/solve_expr.rs
View file

@ -6672,6 +6672,7 @@ mod solve_expr {
main = main =
choice : [T, U] choice : [T, U]
# Should not get generalized
idChoice = idChoice =
#^^^^^^^^{-1} #^^^^^^^^{-1}
when choice is when choice is
@ -6685,7 +6686,7 @@ mod solve_expr {
@r###" @r###"
A#id(4) : A -[[id(4)]]-> A A#id(4) : A -[[id(4)]]-> A
idNotAbility : a -[[idNotAbility(5)]]-> a idNotAbility : a -[[idNotAbility(5)]]-> a
idChoice : a -[[idNotAbility(5)] + a:id(2):1]-> a | a has Id idChoice : A -[[id(4), idNotAbility(5)]]-> A
idChoice : A -[[id(4), idNotAbility(5)]]-> A idChoice : A -[[id(4), idNotAbility(5)]]-> A
"### "###
) )
@ -6707,6 +6708,7 @@ mod solve_expr {
main = main =
choice : [T, U] choice : [T, U]
# Should not get generalized
idChoice = idChoice =
#^^^^^^^^{-1} #^^^^^^^^{-1}
when choice is when choice is
@ -6719,7 +6721,7 @@ mod solve_expr {
), ),
@r#" @r#"
A#id(4) : A -[[id(4)]]-> A A#id(4) : A -[[id(4)]]-> A
idChoice : a -[[] + a:id(2):1]-> a | a has Id idChoice : A -[[id(4)]]-> A
idChoice : A -[[id(4)]]-> A idChoice : A -[[id(4)]]-> A
"# "#
) )
@ -8582,8 +8584,8 @@ mod solve_expr {
"# "#
), ),
@r###" @r###"
a : [A Str]* a : [A Str]w_a
b : [A Str]* b : [A Str]w_a
"### "###
); );
} }